Rebuild for gfortran 7 for OSX (fixed) by beckermr · Pull Request #48 · conda-forge/python-eccodes-feedstock

beckermr · 2019-08-26T14:09:26Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Closes #47
Closes #49

conda-forge-linter · 2019-08-26T14:09:31Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

license_file entry is missing, but is expected.

…da-forge-pinning 2019.08.22

conda-forge-linter · 2019-08-26T14:10:58Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter · 2019-08-26T14:19:35Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter · 2019-08-26T14:26:32Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter · 2019-08-26T14:28:09Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

beckermr · 2019-08-27T11:53:19Z

@conda-forge-admin, please rerender

…da-forge-pinning 2019.08.22

recipe/meta.yaml

recipe/build.sh

beckermr · 2019-08-27T12:17:16Z

And as I thought this will take work:

gcc -pthread -B $PREFIX/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I$PREFIX/include/python3.7m -c gribapi/_bindings.c -o ./gribapi/_bindings.o
unable to execute 'gcc': No such file or directory
ERROR:root:can't compile ecCodes bindings
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/unixccompiler.py", line 118, in _compile
    extra_postargs)
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/ccompiler.py", line 909, in spawn
    spawn(cmd, dry_run=self.dry_run)
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/spawn.py", line 36, in spawn
    _spawn_posix(cmd, search_path, dry_run=dry_run)
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/spawn.py", line 159, in _spawn_posix
    % (cmd, exit_status))
distutils.errors.DistutilsExecError: command 'gcc' failed with exit status 1

beckermr · 2019-08-27T12:17:37Z

I need to add the c compilers too.

conda-forge-linter · 2019-08-27T12:19:27Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter · 2019-08-27T12:19:47Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr · 2019-08-27T12:20:03Z

@conda-forge-admin, please rerender

…da-forge-pinning 2019.08.22

beckermr · 2019-08-27T13:31:51Z

OK @conda-forge/python-eccodes @kmuehlbauer This PR is ready to go. It now builds the python 3 version only and compiles the fast bindings as well!

kmuehlbauer

Great work @beckermr! I'm all for merging this. @ocefpaf might have one last look, if we did not miss anything.

beckermr · 2019-08-30T16:39:45Z

Bump here. We should go ahead and merge.

Update meta.yaml

d17eac3

beckermr changed the title ~~Rebuild for gfortran 7 for OSX (fixed_~~ Rebuild for gfortran 7 for OSX (fixed) Aug 26, 2019

MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.4.1, and con…

f1b6524

…da-forge-pinning 2019.08.22

beckermr added 2 commits August 26, 2019 09:23

Update meta.yaml

7c90d94

Update meta.yaml

c9c5d8d

beckermr added 3 commits August 26, 2019 09:55

Update build.sh

fda05fc

Update build.sh

e198b81

Update meta.yaml

e516ebb

beckermr mentioned this pull request Aug 26, 2019

version madness #49

Closed

beckermr added 2 commits August 27, 2019 06:51

Update meta.yaml

cb045a7

Update build.sh

6675d3f

MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.4.1, and con…

12c1554

…da-forge-pinning 2019.08.22

kmuehlbauer reviewed Aug 27, 2019

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

beckermr added 2 commits August 27, 2019 07:08

Update meta.yaml

0986073

Update build.sh

c58b215

kmuehlbauer reviewed Aug 27, 2019

View reviewed changes

recipe/build.sh Show resolved Hide resolved

Update meta.yaml

f280ebe

Update meta.yaml

abcbe6a

MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.4.1, and con…

83cf6d0

…da-forge-pinning 2019.08.22

beckermr added 4 commits August 27, 2019 07:36

Update build.sh

e2210df

Update meta.yaml

40406b9

Update build.sh

7577c71

Update build.sh

860f5e7

kmuehlbauer approved these changes Aug 27, 2019

View reviewed changes

kmuehlbauer merged commit 479f927 into conda-forge:master Aug 31, 2019

kmuehlbauer mentioned this pull request Oct 4, 2019

Add eccodes python interface conda-forge/staged-recipes#9731

Closed

Uh oh!

Conversation

beckermr commented Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-linter commented Aug 26, 2019

Uh oh!

conda-forge-linter commented Aug 26, 2019

Uh oh!

conda-forge-linter commented Aug 26, 2019

Uh oh!

conda-forge-linter commented Aug 26, 2019

Uh oh!

conda-forge-linter commented Aug 26, 2019

Uh oh!

beckermr commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

beckermr commented Aug 27, 2019

Uh oh!

beckermr commented Aug 27, 2019

Uh oh!

conda-forge-linter commented Aug 27, 2019

Uh oh!

conda-forge-linter commented Aug 27, 2019

Uh oh!

beckermr commented Aug 27, 2019

Uh oh!

beckermr commented Aug 27, 2019

Uh oh!

kmuehlbauer left a comment

Choose a reason for hiding this comment

Uh oh!

beckermr commented Aug 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

beckermr commented Aug 26, 2019 •

edited

Loading